Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for ploomber-cloud labels --sync #261

Merged
merged 8 commits into from
Aug 2, 2024

Conversation

KJSanchez
Copy link
Contributor

@KJSanchez KJSanchez commented Aug 1, 2024

Copy link
Contributor

@bryannho bryannho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KJSanchez Please also add a note in doc/user-guide/managing-apps.md under the Labels section, linking users to the CLI guide. You can do it as a tip:

```{tip}
You can also add labels to your app through the [CLI](link-to-CLI-labels-section)
```

doc/user-guide/cli.md Outdated Show resolved Hide resolved
doc/user-guide/cli.md Show resolved Hide resolved
@KJSanchez
Copy link
Contributor Author

@KJSanchez Please also add a note in doc/user-guide/managing-apps.md under the Labels section, linking users to the CLI guide. You can do it as a tip:

```{tip}
You can also add labels to your app through the [CLI](link-to-CLI-labels-section)

d8d518b

and relevant link to the preview app: https://ploomber-doc--261.org.readthedocs.build/en/261/user-guide/managing-apps.html

@KJSanchez KJSanchez requested a review from bryannho August 1, 2024 22:58
bryannho
bryannho previously approved these changes Aug 1, 2024
@bryannho
Copy link
Contributor

bryannho commented Aug 1, 2024

@KJSanchez let's wait for @neelasha23 to approve this PR and the CLI PR, then we'll merge

@bryannho bryannho merged commit 8fb619a into main Aug 2, 2024
1 check passed
@bryannho bryannho deleted the labels-sync-command branch August 2, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants